Conversation
Marks applied to fixtures have no effect and are now an error in pytest 9 (PytestRemovedIn9Warning). All test functions using this fixture already have their own @pytest.mark.cdn decorator.
Newer Selenium enforces W3C WebDriver spec compliance, rejecting vendor-specific capabilities (avoidProxy, tags) at the top level. These must be nested under sauce:options.
For https://github.com/mozilla/bedrock/actions/runs/21957292026/job/63424850468, it looks like the submit button was clickable but timed out. It might be caused by https://github.com/mozmeao/springfield/blob/main/media/js/newsletter/form-utils.es6.js#L90. If we are using |
Did you mean to link to the springfield repo there? |
Oops, I meant to link the same file in |
|
Would you have any time to try fixing it? (I'll update the merge conflict
around the CDN tests first)
|
|
I can look into this the second half of my day 👍 |
|
I can't speak to the issues with the WNP/Flare newsletter validation — but understand the flakiness is annotated on the Playwright parts (appears to be loading issue, some pages were not returned, some buttons couldn't be clicked; in only one of four browser runs, I'll try to inspect the traces to see what the runner saw, If there's any clue in there), whereas this only touches the Selenium side of things. I previously did successfully upgrade the deps springfield#361 without any impact (the reasons for downpinning seem to no longer exhibit), the only wrinkle was then when e.g. urllib/requests security bump landed, it clashed with the subdeps and that pytest+selenium stack needed to be reverted back to be able to update the vulnerable prod deps. So I'm all for this, let's see if the newer major versions have better dep constraints or release at a faster cadence to cover the vulns as fast as the prod deps to match. |
This catches up with straggling version bumps that historically were painful around pytest-selenium, but I figured it was time to bite the bullet
And.... integration tests are... seemingly happy, but have some error annotations, oddly: https://github.com/mozilla/bedrock/actions/runs/21957292026 and https://github.com/mozilla/bedrock/actions/runs/21959245804 - are these false positives or tolerable negatives @maureenlholland @wen-2018 ?