Skip to content

WT-891: Update CPG Page#17087

Open
bluewave41 wants to merge 4 commits intomainfrom
WT-891-update-cpg-page
Open

WT-891: Update CPG Page#17087
bluewave41 wants to merge 4 commits intomainfrom
WT-891-update-cpg-page

Conversation

@bluewave41
Copy link
Copy Markdown
Collaborator

@bluewave41 bluewave41 commented Mar 24, 2026

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

One-line summary

Clarify that anyone can submit a report about an employee and not just contributors.

Issue / Bugzilla link

WT-891

Testing

Under "How to Give a Report" notice the follow

  • If you have a report **about an employee** instead of If you have a report **by a contributor about an employee**,

@bluewave41 bluewave41 changed the title WT-8o1: Update CPG Page WT-891: Update CPG Page Mar 24, 2026
reporting-if-you-have-a-report-by = If you have a report <strong>by <em>and</em> about</strong> a contributor (for example, the report is made <strong>by</strong> one contributor <strong>about</strong> another contributor), then you should make your report at the <a href="{ $community_hotline }">Community Participation Guidelines hotline</a>.
reporting-if-you-have-a-report-by-email = If you have a report <strong>by <em>and</em> about</strong> a contributor (for example, the report is made <strong>by</strong> one contributor <strong>about</strong> another contributor), then you should make your report at the <a href="{ $mailto_report }">cpg-report@mozilla.com</a>.
reporting-if-you-have-a-report-involving-v2 = If you have a report by a contributor about <strong>an employee</strong>, then you should report at the <a href="{ $employee_hotline }">{ -brand-name-mozilla } Employee hotline</a>. If you are an employee and need to submit a report, please consult { -brand-name-mozilla }'s internal policies and procedures to understand the reporting options available to you.
reporting-if-you-have-a-report-involving-v2 = If you have a report about <strong>an employee</strong>, then you should report at the <a href="{ $employee_hotline }">{ -brand-name-mozilla } Employee hotline</a>. If you are an employee and need to submit a report, please consult { -brand-name-mozilla }'s internal policies and procedures to understand the reporting options available to you.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bluewave41 - thanks for this. I think the more common approach here would be to add a whole new string with a -v3 suffix and set the -v2 as a fallback string in the ftl() call in the template, to allow for a graceful switchover as the new string is localised.

We've got docs on the process at https://mozmeao.github.io/platform-docs/l10n/fluent/#ftl-string-ids but equally @wen-2018 can explain if need be

(I appreciate it's a lot to wrap one's head around - took me a while!)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I missed the entire localization section with all the expanding columns moving things around 😮 I'm gonna go read through this part

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I read through the localization docs and created a new version string along with adding the obsolete tag to the old one.

I think this is how it should be done? I see an automated github issue with a reminder to go through and remove obsolete strings: #17073

I'm still not sure how the actual translation process will work. If in say 2 months v2 was removed and defaulted to v3 I wonder how that would affect say the French translation if it wasn't translated before then

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's how it's done — strings can't change unless it's only cosmetic and mainly affecting English itself — changes that would have zero impact when exposed to other languages (think articles/prepositions, quote formats etc.) — because the only way to signal change, is to decommission the old string, and create a new ID, to propagate that as something in need of a new translation in the l10n systems.

One finicky part is obsoleting a string with a URL if also the URL or the content of the element attributes changes, so there will actually be two link variables, one for each ftl, but you'll figure that one out when you run into it eventually.

The overlap/obsolescence part is mainly convenience to not mix the localized content with default English strings on day 1 while still waiting for translations to come back, if the content allows for the obsolete strings to still be served. (There might be instances where the removed content is just blatantly wrong and needs replacing = removing right away — in which case keeping also blatantly wrong localizations for some time does not help anyone so these can also be rotated without a fallback ftl right away.) ~ So that generally conveys the 3month window is for any locale to catch up, at which point the old string is considered too old and removed, and if still untranslated it would start showing in English for given locale.

@bluewave41 bluewave41 marked this pull request as draft March 24, 2026 18:31
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.70%. Comparing base (9b2c6aa) to head (864e84c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17087   +/-   ##
=======================================
  Coverage   81.70%   81.70%           
=======================================
  Files         174      174           
  Lines        9326     9326           
=======================================
  Hits         7620     7620           
  Misses       1706     1706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

reporting-if-you-have-a-report-by-email = If you have a report <strong>by <em>and</em> about</strong> a contributor (for example, the report is made <strong>by</strong> one contributor <strong>about</strong> another contributor), then you should make your report at the <a href="{ $mailto_report }">cpg-report@mozilla.com</a>.
# Obsolete string (expires: 2026-05-24)
reporting-if-you-have-a-report-involving-v2 = If you have a report by a contributor about <strong>an employee</strong>, then you should report at the <a href="{ $employee_hotline }">{ -brand-name-mozilla } Employee hotline</a>. If you are an employee and need to submit a report, please consult { -brand-name-mozilla }'s internal policies and procedures to understand the reporting options available to you.
reporting-if-you-have-a-report-involving-v3 = If you have a report about <strong>an employee</strong>, then you should report at the <a href="{ $employee_hotline }">{ -brand-name-mozilla } Employee hotline</a>. If you are an employee and need to submit a report, please consult { -brand-name-mozilla }'s internal policies and procedures to understand the reporting options available to you.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A hint if you dislike increasing versions like me — the ID should actually reflect the content to some extent. So in this case, when the sentence changes, you don't have to stick to the ID and increase the version. You can opt for any ID that's unused, so that could be:

Suggested change
reporting-if-you-have-a-report-involving-v3 = If you have a report about <strong>an employee</strong>, then you should report at the <a href="{ $employee_hotline }">{ -brand-name-mozilla } Employee hotline</a>. If you are an employee and need to submit a report, please consult { -brand-name-mozilla }'s internal policies and procedures to understand the reporting options available to you.
reporting-if-you-have-a-report-about-employee = If you have a report about <strong>an employee</strong>, then you should report at the <a href="{ $employee_hotline }">{ -brand-name-mozilla } Employee hotline</a>. If you are an employee and need to submit a report, please consult { -brand-name-mozilla }'s internal policies and procedures to understand the reporting options available to you.

in this case, reflecting the actual changed content. (+the template occurrence update to match)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tip. I don't like "v3" at all.

@bluewave41 bluewave41 marked this pull request as ready for review April 8, 2026 18:56
@bluewave41 bluewave41 requested a review from a team as a code owner April 8, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants