Open
Conversation
… reduced, horizontal gutter added to cards.
maureenlholland
requested changes
Apr 1, 2026
Collaborator
maureenlholland
left a comment
maureenlholland
left a comment
There was a problem hiding this comment.
large font works 🎉
requested changes
- more robust accessible naming
- fix regression on the news logos
| .mzan-card-logo { | ||
| max-width: 160px; | ||
| max-height: 60px; | ||
| width: 160px; |
Collaborator
There was a problem hiding this comment.
regression on news logos
|
|
||
| .mzan-card { | ||
| padding: 16px 0; | ||
| padding: 1rem; |
Collaborator
There was a problem hiding this comment.
nice! fixes missing inline spacing in prod
Collaborator
There was a problem hiding this comment.
Suggested change
| <a href="{{ item_url }}" class="mzan-news-external-link"> |
the if/else condition means the sr-only text isn't always available, so we could make that always available or use an aria labelling solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses all of @maureenlholland's revision requests here:
https://lincolnloop.slack.com/archives/C093QTR6JF4/p1774953071856539