MNTOR-5144 - Remove deprecated hasPremium usage from shutdown banner #6354
+15
−439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemist
commented
Dec 18, 2025
| // Free users who haven't run a scan have no data that would be lost: | ||
| (!props.shutdownState.ranScan && !props.shutdownState.hasPremium) || | ||
| props.shutdownState.currentMoment === "ye-olden-days" || | ||
| props.countryCode !== "us" || |
Collaborator
Author
There was a problem hiding this comment.
I actually don't think the countryCode prop was being used anywhere in this component, so I'm adding it here.
Collaborator
There was a problem hiding this comment.
Heh indeed I ended up not using it, since it was implied by the user having run a scan. We need it now if we're no longer keeping track of who ran scans though, so 👍
codemist
changed the title
Vinnl
approved these changes
Dec 18, 2025
| // Free users who haven't run a scan have no data that would be lost: | ||
| (!props.shutdownState.ranScan && !props.shutdownState.hasPremium) || | ||
| props.shutdownState.currentMoment === "ye-olden-days" || | ||
| props.countryCode !== "us" || |
Collaborator
There was a problem hiding this comment.
Heh indeed I ended up not using it, since it was implied by the user having run a scan. We need it now if we're no longer keeping track of who ran scans though, so 👍
src/app/functions/universal/user.ts
Outdated
Co-authored-by: Vincent <Vinnl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-5144
Figma:
Description
This PR removes the
hasPremiumlogic from the app. At this point,hasPremiumwas only being used to drive shutdown banner behavior, and is no longer needed now that the banner logic has been reduced down to a single state (post-shutdown).Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)