Skip to content

Fix #1907: menus don't have a dark theme anymore #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flukeout merged 1 commit into from
Mar 28, 2017
Merged

Fix #1907: menus don't have a dark theme anymore #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/view/ThemeManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ define(function (require, exports, module) {
return result.content;
})
.then(function (cssContent) {
$("body").toggleClass("dark", theme.dark);
Copy link

@Pomax Pomax Mar 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fix seems to assume a binary theme choice in that if there is any theme at all, it must be the dark theme. That will break the moment we introduce a third theme, or custom theming, so it would be better to check which theme should actually be active. Maybe @flukeout can help point in the right direction here

styleNode.text(cssContent);
$("body").attr('data-theme',theme.name);
pending.resolve(theme);
Expand Down