Support linking to a specific line #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixteman
approved these changes
Sep 27, 2019
Contributor
calixteman
left a comment
calixteman
left a comment
There was a problem hiding this comment.
Pretty complex for such a little thing, but it works pretty well.
Thanks
Contributor
Author
|
That's the joy of playing with Vanilla.Js 😈 |
marco-c
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a bit more complicated than I initially thought, as we cannot use the hash mechanism (we are already using it for navigation !).
So i intercept click on
a.scrolllinks, and directly update the display, without triggering a data reload that would reset the full display.I also cleaned up the
displaymethod a bit, by using dedicated views for the directory & file views (which makes more sense). It's in the first commit, and could be in a separate PR if needed.Demo on the current build