Store normandy id fixes #910#1073
Merged
Merged
Conversation
mythmon
reviewed
Mar 19, 2019
Contributor
There was a problem hiding this comment.
This doesn't look right. Did this get left out of a previous PR?
Collaborator
Author
There was a problem hiding this comment.
Maybe we should add a step to continuous integration to check that no migrations got missed.
Contributor
There was a problem hiding this comment.
I think we should, yeah. We did it on Normandy recently, and it was a pretty easy check.
Do you want to leave this here and merge as is, or do you want to do something to fix this?
Collaborator
Author
There was a problem hiding this comment.
Well It has to go in and I don't see the point of splitting it into its own tiny PR so I'm fine with this as is.
mythmon
approved these changes
Mar 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.