Skip to content

Tweak sort tests #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredlockhart merged 2 commits into from
Mar 28, 2019
Merged

Tweak sort tests #1122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec12ef8
Fix typo in test name
glasserc Mar 27, 2019
67b09f9
Add a test that ExperimentListView respects firefox_channel_sort
glasserc Mar 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion app/experimenter/experiments/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def test_filters_by_firefox_channel(self):
)


class TestExperimengOrderingForm(TestCase):
class TestExperimentOrderingForm(TestCase):

def test_accepts_valid_ordering(self):
ordering = ExperimentOrderingForm.ORDERING_CHOICES[1][0]
Expand Down Expand Up @@ -300,6 +300,36 @@ def test_list_view_filters_and_orders_experiments(self):
list(context["experiments"]), list(filtered_ordered_experiments)
)

def test_list_view_orders_experiments_firefox_channel_sort(self):
user_email = "user@example.com"
ordering = "firefox_channel_sort"
channels = [
Experiment.CHANNEL_RELEASE,
Experiment.CHANNEL_NIGHTLY,
Experiment.CHANNEL_BETA,
"",
]
for channel in channels:
ExperimentFactory.create(firefox_channel=channel)

response = self.client.get(
"{url}?{params}".format(
url=reverse("home"), params=urlencode({"ordering": ordering})
),
**{settings.OPENIDC_EMAIL_HEADER: user_email},
)

context = response.context[0]
self.assertEqual(
list(exp.firefox_channel for exp in context["experiments"]),
[
"",
Experiment.CHANNEL_NIGHTLY,
Experiment.CHANNEL_BETA,
Experiment.CHANNEL_RELEASE,
],
)

def test_list_view_total_experiments_count(self):
user_email = "user@example.com"

Expand Down