Skip to content

Fix google analytics tests fixes #1189 #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredlockhart merged 1 commit into from
Apr 18, 2019
Merged

Fix google analytics tests fixes #1189 #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions app/experimenter/base/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,19 @@

class TestContextProcessors(TestCase):

def test_render_google_analytics_or_not(self):
headers = {settings.OPENIDC_EMAIL_HEADER: "user@example.com"}
response = self.client.get(reverse("home"), **headers)
self.assertEqual(response.status_code, 200)
html = response.content.decode("utf-8")
self.assertTrue("www.googletagmanager.com" in html)

def test_google_analytics_omitted_if_setting_false(self):
with self.settings(USE_GOOGLE_ANALYTICS=False):
headers = {settings.OPENIDC_EMAIL_HEADER: "user@example.com"}
response = self.client.get(reverse("home"), **headers)
self.assertEqual(response.status_code, 200)
html = response.content.decode("utf-8")
# Note the 'not'!
self.assertTrue("www.googletagmanager.com" not in html)
self.assertNotIn("www.googletagmanager.com", html)

def test_google_analytics_included_if_setting_true(self):
with self.settings(USE_GOOGLE_ANALYTICS=True):
headers = {settings.OPENIDC_EMAIL_HEADER: "user@example.com"}
response = self.client.get(reverse("home"), **headers)
self.assertEqual(response.status_code, 200)
html = response.content.decode("utf-8")
self.assertIn("www.googletagmanager.com", html)