Closed
Conversation
Otherwise the file might be empty looking to outsiders. At least on Windows this caused test failures in m-c when we were implement a prototype-health ping and checking files on disk. Only by syncing it all do we actually get the right file size on disk. Before we used to open/close the event database files all the time, which internally does a sync. Now `sync_all` is potentially _more_ expensive than a close (through drop), as the latter is not required to block until the data is written (according to the docs: https://doc.rust-lang.org/std/fs/struct.File.html#method.sync_all)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the file might be empty looking to outsiders. At least on Windows this caused test failures in m-c when we were implement a prototype-health ping and checking files on disk.
Only by syncing it all do we actually get the right file size on disk.
Before we used to open/close the event database files all the time, which internally does a sync.
Now
sync_allis potentially more expensive than a close (through drop), as the latter is not required to block until the data is written (according to the docs: https://doc.rust-lang.org/std/fs/struct.File.html#method.sync_all)