Conversation
badboy
force-pushed
the
push-nosprmmpsxxz
branch
from
e857ee0 to
3c706f8
Compare
…before recording on it This _should not_ happen, but apparently it does in Fenix. I have no idea why or how to prevent it. But we can mitigate it. Downside: If the instance is not instantiated by the time `set` actually runs we don't record any data. But then again before we just crashed, which also didn't record data.
badboy
force-pushed
the
push-nosprmmpsxxz
branch
from
3c706f8 to
12e48c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not happen, but apparently it does in Fenix. I have no idea why or how to prevent it.
But we can mitigate it.
Downside: If the instance is not instantiated by the time
setactually runs we don't record any data. But then again before we just crashed, which also didn't record data.