Bug 1986171 - Bump maturin to 1.10.1 and always use UniFFI's library mode to generate bindings#3317
Merged
Bug 1986171 - Bump maturin to 1.10.1 and always use UniFFI's library mode to generate bindings#3317
Conversation
badboy
changed the title
badboy
force-pushed
the
push-qxkvnplxyxxt
branch
3 times, most recently
from
e299d94 to
908e581
Compare
badboy
changed the title
badboy
force-pushed
the
push-qxkvnplxyxxt
branch
from
908e581 to
f4bf002
Compare
badboy
force-pushed
the
push-qxkvnplxyxxt
branch
from
f4bf002 to
7d28a90
Compare
badboy
changed the title
That's what maturin now does for Python anyway.
badboy
force-pushed
the
push-qxkvnplxyxxt
branch
from
7d28a90 to
0dda088
Compare
Member
Author
|
I have changed how the wheels for them are build in subsequent commits, try run is here: https://app.circleci.com/pipelines/github/mozilla/glean/14015/workflows/32ea8d58-c4ad-4c7d-bfe0-77fa1cdd0fba/jobs/275271 That works, but produces larger libraries, due to the symbols being in there now, which we need. I need to verify this still works correctly. |
jeddai
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.