Swift 6 migration - PingUploader callback should be Sendable#3325
Merged
badboy merged 1 commit intomozilla:mainfrom Nov 17, 2025
Merged
Swift 6 migration - PingUploader callback should be Sendable#3325badboy merged 1 commit intomozilla:mainfrom
badboy merged 1 commit intomozilla:mainfrom
Conversation
7 tasks
badboy
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We're fixing some warnings as part of the Swift 6 migration. We're slowly chipping away at strict concurrency warnings under the Firefox iOS project.
Description
We're using the custom ping uploader protocol, which callback should be made
@Sendable.UploadResultis an enum, which means it can be Sendable (or sent across isolation boundaries) as it's a value type.