Skip to content

Bug 2004001 - Disable post_init health ping#3343

Merged
badboy merged 1 commit intomainfrom
push-wnotxvqltppr
Dec 9, 2025
Merged

Bug 2004001 - Disable post_init health ping#3343
badboy merged 1 commit intomainfrom
push-wnotxvqltppr

Conversation

@badboy
Copy link
Copy Markdown
Member

@badboy badboy commented Dec 4, 2025

No description provided.

@badboy badboy requested a review from a team as a code owner December 4, 2025 11:46
@badboy badboy requested review from travis79 and removed request for a team December 4, 2025 11:46
@badboy badboy force-pushed the push-wnotxvqltppr branch from 2ff7b30 to 8f0dbc9 Compare December 4, 2025 11:47
@badboy badboy marked this pull request as draft December 4, 2025 11:47
@travis79
Copy link
Copy Markdown
Member

travis79 commented Dec 4, 2025

oof, lots of tests will need "fixed" to rely on the new number of "startup" pings. (Sorry about that...)

@badboy
Copy link
Copy Markdown
Member Author

badboy commented Dec 4, 2025

oof, lots of tests will need "fixed" to rely on the new number of "startup" pings. (Sorry about that...)

Nah, I expected that. For now I only did the minimal amount of work. We'll discuss in the WG meeting later.

@badboy badboy force-pushed the push-wnotxvqltppr branch from 8f0dbc9 to 2b63244 Compare December 4, 2025 12:56
Comment thread glean-core/rlb/tests/health_ping_file_overwrite.rs Outdated
Comment thread glean-core/pings.yaml
@badboy badboy force-pushed the push-wnotxvqltppr branch from 2b63244 to 097e87e Compare December 5, 2025 13:59
@badboy badboy marked this pull request as ready for review December 5, 2025 13:59
@badboy badboy requested a review from travis79 December 8, 2025 11:44
@badboy badboy force-pushed the push-wnotxvqltppr branch from 097e87e to d93a9ab Compare December 8, 2025 13:53
@badboy badboy enabled auto-merge (rebase) December 8, 2025 13:53
Copy link
Copy Markdown
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for leaving documentation about the "post-init" reason. This now looks good to me.

@badboy badboy merged commit 1296b44 into main Dec 9, 2025
27 of 28 checks passed
@badboy badboy deleted the push-wnotxvqltppr branch December 9, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants