Skip to content

Include benches directory in crate distribution#3359

Merged
badboy merged 1 commit intomainfrom
push-tmtomkzvrspx
Dec 19, 2025
Merged

Include benches directory in crate distribution#3359
badboy merged 1 commit intomainfrom
push-tmtomkzvrspx

Conversation

@badboy
Copy link
Copy Markdown
Member

@badboy badboy commented Dec 18, 2025

Otherwise the package is incomplete. And the Python source tarballs won't have this file and thus won't build.

@badboy badboy requested a review from a team as a code owner December 18, 2025 10:35
@badboy badboy requested review from travis79 and removed request for a team December 18, 2025 10:35
@badboy
Copy link
Copy Markdown
Member Author

badboy commented Dec 18, 2025

Running make build-python-sdist in the Glean repository.
Then running this in a fresh Python virtual environment:

pip install path/to/glean/target/wheel/glean_sdk-66.2.0.tar.gz

takes a bit of time as it compiles the whole thing, but it then works.

<snip>
Successfully built glean-sdk
Installing collected packages: glean-sdk
Successfully installed glean-sdk-66.2.0

@badboy badboy enabled auto-merge (rebase) December 18, 2025 10:44
Otherwise the package is incomplete. And the Python source tarballs
won't have this file and thus won't build.
@badboy badboy changed the title Include benches in crate Include benches directory in crate distribution Dec 18, 2025
@badboy badboy disabled auto-merge December 19, 2025 13:05
@badboy badboy merged commit 28a4d35 into main Dec 19, 2025
27 of 28 checks passed
@badboy badboy deleted the push-tmtomkzvrspx branch December 19, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant