Skip to content

Bug 2034605 - Switch to an SQLite storage backend #3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
badboy wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Bug 2034605 - Switch to an SQLite storage backend #3405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
8b3ca10
Import sqlite storage as separate module
badboy Jun 5, 2025
15df539
Rust dependency: Add `rusqlite`
badboy Jun 5, 2025
be30dc5
Vetting newly imported crates
badboy Feb 20, 2026
6e4578c
Use the sqlite module as the database layer
badboy Jun 5, 2025
17bfdf2
Serialize values using MessagePack instead of bincode
badboy Jan 21, 2026
b095a0e
Implement the label verifier against sqlite storage
badboy Jan 28, 2026
da7e06f
Correctly assemble payload for labeled metrics
badboy Jan 29, 2026
d9198ec
Simplify getting metrics out again
badboy Jan 30, 2026
1bc9f9a
sqlite: Implement clearing of lifetime storage
badboy Jan 30, 2026
fe7f105
sqlite: Measure database on-disk size by scanning the directory
badboy Jan 30, 2026
8e20a22
Handle static labels like dynamic ones: stored along with the metric
badboy Feb 2, 2026
1d81dbb
Copy over is_ping_enabled check instead of is_upload_enabled
badboy Feb 2, 2026
6e5f26d
Rework how dynamic labels are validated
badboy Feb 2, 2026
e75e188
Correctly validate usage of key-only/category-only dual-labels
badboy Feb 2, 2026
588e805
Remove now-unused database code
badboy Feb 4, 2026
b8f1973
Switch to get_metric everywhere
badboy Feb 4, 2026
8cdb98d
Return a specific LabelCheck that knows how to report an error at a l…
badboy Feb 5, 2026
4138c13
Remove strip_label usage now that labels are stored separately
badboy Feb 5, 2026
9079897
Implement get_identifiers based on the new label storage.
badboy Feb 6, 2026
4d49c82
sqlite: Set synchronous=NORMAL to sync less often, but at the critica…
badboy Feb 6, 2026
60d0e22
Rename to `MetricLabel` now that it's always used to store the label
badboy Feb 13, 2026
ba6b882
Implement rkv->sqlite migration
badboy Feb 13, 2026
880a6b7
Re-enable client_id tests
badboy Feb 16, 2026
ed8a7e0
Handle error recording in a single place again
badboy Feb 16, 2026
8e5fe3a
Test: ensure we don't record errors if we aren't enabled
badboy Feb 16, 2026
624cb28
Handle sqlite load errors
badboy Feb 16, 2026
e6b6df1
Test several sqlite edge cases
badboy Feb 17, 2026
98425c1
Test what happens if database is otherwise locked
badboy Feb 17, 2026
14f4642
Handle possible SQLite query errors and bubble them up instead of bli…
badboy Feb 19, 2026
7872360
A test to verify that all metrics are properly migrated.
badboy Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 101 additions & 11 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions glean-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ uniffi = { version = "0.31.0", default-features = false }
env_logger = { version = "0.10.0", default-features = false, optional = true }
malloc_size_of_derive = "0.1.3"
malloc_size_of = { version = "0.2.2", package = "wr_malloc_size_of", default-features = false, features = ["once_cell"] }
rusqlite = { version = "0.37.0", features = ["bundled"] }
rmp-serde = "1.3.1"

[target.'cfg(target_os = "android")'.dependencies]
android_logger = { version = "0.12.0", default-features = false }
Expand Down
Loading
Loading