Skip to content

[bug 926611] Fix y axis re-scaling on aggregated charts. #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rlr wants to merge 1 commit into from
Closed

[bug 926611] Fix y axis re-scaling on aggregated charts. #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion kitsune/sumo/static/js/rickshaw_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,11 @@ k.Graph.prototype.rebucket = function() {
max: -Infinity
};
}
this.axisGroups[name].max = Math.max(this.axisGroups[name].max, series.max);

// Only adjust the axis max if the series is enabled.
if (!series.disabled) {
this.axisGroups[name].max = Math.max(this.axisGroups[name].max, series.max);
}
}

for (i = 0; i < this.data.series.length; i++) {
Expand Down
1 change: 1 addition & 0 deletions kitsune/sumo/static/js/wiki.dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ function makeAggregatedWikiMetricGraphs() {
graph.data.seriesSpec[index].disabled = true;
}
});
graph.rebucket();
Copy link
Contributor

@mythmon mythmon Oct 17, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My flakey memory tells me that I left this out for performance reasons last time. Does this have a negative affect on the KPI graphs? If nothing else, you should probably remove calls to .rebucket() anywhere else that .update() is called (like in the slider.)

Copy link
Contributor Author

@rlr rlr Oct 17, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only affects the one page. And yeah, it is pretty slow to update when you check/uncheck locales... but whatevs.

Copy link
Contributor

@mythmon mythmon Oct 17, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, oops. I thought this was in rickshaw_utils.js.

graph.update();
});
}
Expand Down