Skip to content

Conversation

@rlr
Copy link
Contributor

@rlr rlr commented Oct 28, 2013

Adds an autocomplete widget to question filtering (by tag) form:

r?

@mythmon
Copy link
Contributor

mythmon commented Oct 28, 2013

Travis kicked up some errors in the qunit suite (yay Travis!) that look related to this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's it?

@rlr
Copy link
Contributor Author

rlr commented Oct 28, 2013

oh nice. I'll look into the qunit fails.

@rlr
Copy link
Contributor Author

rlr commented Oct 28, 2013

that should fix the tests ^

@rlr
Copy link
Contributor Author

rlr commented Oct 28, 2013

yay, travis is happy now ^

@willkg
Copy link
Member

willkg commented Oct 31, 2013

How do you test this? Just go to /en-US/questions, open the sort/filter thing and start typing in the filter box?

It doesn't seem to do anything for me.

@rlr
Copy link
Contributor Author

rlr commented Oct 31, 2013

Yeah just that. After one letter it should show the autocomplete dropdown. I just tried logged in and not and wfm. hmmm 😕

@willkg
Copy link
Member

willkg commented Oct 31, 2013

I can't tell if I've got something set up wrong or what, but it's definitely not doing anything in Firefox Nightly.

@rlr
Copy link
Contributor Author

rlr commented Oct 31, 2013

OK, I'll try nightly too. Anything in the dev tools console (JS tab)?

@willkg
Copy link
Member

willkg commented Oct 31, 2013

Blah. I was on the wrong branch. Works for me! r+

@rlr
Copy link
Contributor Author

rlr commented Oct 31, 2013

31cf6f9 [bug 911581] Add autocomplete to tag filtering on /questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants