-
Notifications
You must be signed in to change notification settings - Fork 824
[bug 911581] Add autocomplete to tag filtering on /questions. #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Travis kicked up some errors in the qunit suite (yay Travis!) that look related to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's it?
|
oh nice. I'll look into the qunit fails. |
|
that should fix the tests ^ |
|
yay, travis is happy now ^ |
|
How do you test this? Just go to /en-US/questions, open the sort/filter thing and start typing in the filter box? It doesn't seem to do anything for me. |
|
Yeah just that. After one letter it should show the autocomplete dropdown. I just tried logged in and not and wfm. hmmm 😕 |
|
I can't tell if I've got something set up wrong or what, but it's definitely not doing anything in Firefox Nightly. |
|
OK, I'll try nightly too. Anything in the dev tools console (JS tab)? |
|
Blah. I was on the wrong branch. Works for me! r+ |
|
31cf6f9 [bug 911581] Add autocomplete to tag filtering on /questions. |
Adds an autocomplete widget to question filtering (by tag) form:
r?