Fix issue with Bugzilla.put: some bugs were updated multiple times #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-c
reviewed
Dec 16, 2018
libmozdata/bugzilla.py
Outdated
| header = self.get_header() | ||
| user = BugzillaUser().get_whoami() | ||
| if not user: | ||
| raise BugzillaException('Not a valid user is associated to the given token') |
Collaborator
There was a problem hiding this comment.
There is no valid user associated to ...
marco-c
reviewed
Dec 16, 2018
| return failures | ||
|
|
||
| success = False | ||
| for _ in range(max_retry): |
Collaborator
There was a problem hiding this comment.
We should probably wait a bit before trying again.
marco-c
reviewed
Dec 16, 2018
libmozdata/bugzilla.py
Outdated
| last = get_last(bzmail, history) | ||
|
|
||
| if not last: | ||
| raise BugzillaException('Impossible to get update the bug {}'.format(first_id)) |
Collaborator
There was a problem hiding this comment.
Impossible to get last update to the ...
marco-c
reviewed
Dec 16, 2018
libmozdata/bugzilla.py
Outdated
| last_time = dateutil.parser.parse(last['when']) | ||
|
|
||
| success = False | ||
| for _ in range(max_retry): |
Collaborator
There was a problem hiding this comment.
Same here, we might want to wait a bit between retries.
marco-c
approved these changes
Dec 16, 2018
Collaborator
marco-c
left a comment
marco-c
left a comment
There was a problem hiding this comment.
LGTM overall, but it is really complex. Could we just update one bug at a time instead? Or do you need it to be fast?
Contributor
|
Hi @calixteman 🙂 are you still waiting for my review? If so, I can try taking a look soon, otherwise please feel free to rebase / merge this without my review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update on a chunk can return an error when only one bug fail to update and so in that case we triggered an update for all the chunk which leaded to dup updates in some bugs.
So the goal is to fix that:
i) use requests instead of requests_futures: no need to nag bmo
ii) in case of failures: check the history of the bugs in the chunk to find the failing ones