You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 12, 2018. It is now read-only.
What's happening is that we have a map [a v] -> e expressed as a composition of maps:
[a v] -> temporary search id
temporary search id -> e entid from database
The latter map must be chunked into a number of sub-queries because SQLite allows to bind only a limited number of variables.
The reviewer correctly points out that we don't need to collect as many intermediate data structures. We could do this as iteration and a mutable map, although I think I prefer a big fold. A "fold-in-place" is best expressed as a for loop in Rust (per the documentation), which is what the reviewer asks for.
This ticket isn't quite ready, because the [a v] lookup code is likely to change a little with #184.
This is follow-up to #214 (comment).
What's happening is that we have a map
[a v] -> eexpressed as a composition of maps:[a v]-> temporary search ideentid from databaseThe latter map must be chunked into a number of sub-queries because SQLite allows to bind only a limited number of variables.
The reviewer correctly points out that we don't need to collect as many intermediate data structures. We could do this as iteration and a mutable map, although I think I prefer a big
fold. A "fold-in-place" is best expressed as aforloop in Rust (per the documentation), which is what the reviewer asks for.This ticket isn't quite ready, because the [a v] lookup code is likely to change a little with #184.