This repository was archived by the owner on Sep 12, 2018. It is now read-only.

Schema alteration.#370

Merged

ncalexan merged 27 commits into

mozilla:rustfrom

ncalexan:idents

Mar 20, 2017

Commits on Mar 20, 2017

Pre: s/VALUETYPE/VALUE_TYPE/.
ncalexan
committed
Pre: Don't retract :db/ident in test.
ncalexan
committed
Pre: Remove some single quotes from error output.
ncalexan
committed
Pre: Map TypedValue::Ref to TypedValue::Keyword in debug output.
ncalexan
committed
Pre: Add DiffSet.
ncalexan
committed
Part 1: Make materialized views be uniform [e a v value_type_tag].
ncalexan
committed
Part 2: Maintain entids separately from idents.
ncalexan
committed
Part 3: Separate `schema_to_mutate` from the `schema` used to interpret.
ncalexan
committed
Part 4: Collect mutations to a `Schema`.
ncalexan
committed
Part 5: Handle :db/ident and :db.{install,alter}/attribute.
ncalexan
committed
Review comment: Rename DiffSet to AddRetractAlterSet.
ncalexan
committed
Review comment: Use ToIdent trait.
ncalexan
committed
Review comment: partially revert "Part 2: Maintain entids separately from idents."
ncalexan
committed
Review comment: Don't preserve historical idents.
ncalexan
committed
Review comment: More prepared statements when updating materialized views.
ncalexan
committed
Post: Use custom Either rather than std::result::Result.
ncalexan
committed
Post: Test altering :db/cardinality and :db/unique.
ncalexan
committed
Post: Remove some more single quotes from error output.
ncalexan
committed
Post: Add assert_transact! macro to unwrap safely.
ncalexan
committed
Post: Don't expect or recognize :db.{install,alter}/attribute.
ncalexan
committed
Post: Don't make :db/unique :db.unique/* imply :db/index true.
ncalexan
committed
Post: Allow to retract :db/ident.
ncalexan
committed
Post: Include more details about invalid schema changes.
ncalexan
committed
Review comment: Fix outdated comment.
ncalexan
committed
Review comment: s/_SET/_SQL_LIST/.
ncalexan
committed
Review comment: Use a sub-select for checking cardinality.
ncalexan
committed
Review comment: Put `attribute::Unique` into its own namespace.
ncalexan
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Schema alteration.#370

Schema alteration.#370
ncalexan merged 27 commits into
mozilla:rustfrom
ncalexan:idents

Commits on Mar 20, 2017

Pre: s/VALUETYPE/VALUE_TYPE/.

Pre: Don't retract :db/ident in test.

Pre: Remove some single quotes from error output.

Pre: Map TypedValue::Ref to TypedValue::Keyword in debug output.

Pre: Add DiffSet.

Part 1: Make materialized views be uniform [e a v value_type_tag].

Part 2: Maintain entids separately from idents.

Part 3: Separate `schema_to_mutate` from the `schema` used to interpret.

Part 4: Collect mutations to a `Schema`.

Part 5: Handle :db/ident and :db.{install,alter}/attribute.

Review comment: Rename DiffSet to AddRetractAlterSet.

Review comment: Use ToIdent trait.

Review comment: partially revert "Part 2: Maintain entids separately from idents."

Review comment: Don't preserve historical idents.

Review comment: More prepared statements when updating materialized views.

Post: Use custom Either rather than std::result::Result.

Post: Test altering :db/cardinality and :db/unique.

Post: Remove some more single quotes from error output.

Post: Add assert_transact! macro to unwrap safely.

Post: Don't expect or recognize :db.{install,alter}/attribute.

Post: Don't make :db/unique :db.unique/* imply :db/index true.

Post: Allow to retract :db/ident.

Post: Include more details about invalid schema changes.

Review comment: Fix outdated comment.

Review comment: s/_SET/_SQL_LIST/.

Review comment: Use a sub-select for checking cardinality.

Review comment: Put `attribute::Unique` into its own namespace.