This repository was archived by the owner on Sep 12, 2018. It is now read-only.
Arc, refactored#659
Merged
Merged
Conversation
ncalexan
approved these changes
Apr 25, 2018
Member
ncalexan
left a comment
ncalexan
left a comment
There was a problem hiding this comment.
I don't have strong feelings about this. If this is the way that one abstracts over the reference type, I'm fine with it. (I definitely don't want everything to be generic over a new R type!)
| } | ||
|
|
||
| // | ||
| // Use Rc for values. |
Member
There was a problem hiding this comment.
This comment isn't great. At first I thought it was just wrong, but now I see that this isn't an alias, it's picking one of Rc<T> and the implicitly not chosen Arc<T>.
Collaborator
Author
|
Comments improved, FFI works, and we can now use @fluffyemily, please post-review a6ec3f2 if this lands during your nighttime. Our test times are incredibly stable, with no variance visible between the types.
|
ncalexan
added a commit
to ncalexan/mentat
that referenced
this pull request
May 3, 2018
) @mmacedoeu did a good deal of work to show that Arc instead of Rc wasn't too difficult in mozilla#656, and @rnewman pushed the refactoring across the line in mozilla#659. However, we didn't flip the switch at that time. For mozilla#673, we'd like to include TypedValue instances in errors, and with error-chain (and failure) error types need to be 'Sync + 'Send, so we need Arc. This builds on mozilla#659 and should also finish mozilla#656.
rnewman
pushed a commit
that referenced
this pull request
May 3, 2018
) r=rnewman @mmacedoeu did a good deal of work to show that Arc instead of Rc wasn't too difficult in #656, and @rnewman pushed the refactoring across the line in #659. However, we didn't flip the switch at that time. For #673, we'd like to include TypedValue instances in errors, and with error-chain (and failure) error types need to be 'Sync + 'Send, so we need Arc. This builds on #659 and should also finish #656.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Informally I don't see significant performance differences with this. More timing to do; you can switch between
RcandArcby switching the commenting for a few lines intypes.rs.This PR is like #656 but reproduced independently on top of #658. There are a few changes that should go into #658, and not all the code builds yet, but
cargo test -p mentat --test querywill run.