-
Notifications
You must be signed in to change notification settings - Fork 12
Add new experiments_column_type to support events_stream tables #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,9 @@ | |
| from mozanalysis.metrics import AnalysisBasis, DataSource, Metric | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("experiments_column_type", [None, "simple", "native", "glean"]) | ||
| @pytest.mark.parametrize( | ||
| "experiments_column_type", [None, "simple", "native", "glean", "events_stream"] | ||
| ) | ||
| def test_datasource_constructor_succeeds(experiments_column_type): | ||
| DataSource( | ||
| name="foo", | ||
|
Comment on lines
10
to
15
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems like there should be more tests than this (e.g., for the two functions you modified here). I know we have more comprehensive testing in jetstream so maybe not a big deal, but if you've got some time and inclination now want to tackle that here? Otherwise can you just file a ticket (in mozanalysis issues is good) to add unit tests for those two functions? |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I think you're right that this matches the other checks a little more closely than just checking the branch alone, and either way it's no harm to check the experiment + branch.