Skip to content

feat: compute sample_id dynamically for enrollments #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mikewilli wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Draft

feat: compute sample_id dynamically for enrollments #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5afc05
feat: compute sample_id dynamically for enrollments
mikewilli Apr 13, 2026
33be134
updates
mikewilli Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/mozanalysis/experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,7 @@ def _build_enrollments_query_normandy(
return f"""
SELECT
e.{self.analysis_unit.value} AS analysis_id,
udf.safe_sample_id({self.analysis_unit.value}) AS sample_id,
`mozfun.map.get_key`(e.event_map_values, 'branch')
AS branch,
MIN(e.submission_date) AS enrollment_date,
Expand Down Expand Up @@ -877,6 +878,7 @@ def _build_enrollments_query_fenix_baseline(
return """
SELECT
b.client_info.client_id AS analysis_id,
udf.safe_sample_id(b.client_info.client_id) AS sample_id,
mozfun.map.get_key(
b.ping_info.experiments,
'{experiment_slug}'
Expand Down Expand Up @@ -918,6 +920,7 @@ def _build_enrollments_query_glean_events_stream(
return f"""
SELECT
{analysis_id} AS analysis_id,
udf.safe_sample_id({analysis_id}) AS sample_id,
JSON_VALUE(event_extra, '$.branch') AS branch,
DATE(MIN(submission_timestamp)) AS enrollment_date,
COUNT(submission_timestamp) AS num_enrollment_events
Expand Down Expand Up @@ -947,6 +950,7 @@ def _build_enrollments_query_glean_events_stream_enrollment_status(
return f"""
SELECT
client_id AS analysis_id,
udf.safe_sample_id(analysis_id) AS sample_id,
JSON_VALUE(event_extra, '$.branch') AS branch,
DATE(MIN(submission_timestamp)) AS enrollment_date,
COUNT(submission_timestamp) AS num_enrollment_events
Expand Down Expand Up @@ -980,6 +984,7 @@ def _build_enrollments_query_cirrus(
return f"""
SELECT
mozfun.map.get_key(e.extra, "nimbus_user_id") AS analysis_id,
0 AS sample_id,
mozfun.map.get_key(
e.extra,
'branch'
Expand Down
1 change: 1 addition & 0 deletions tests/test_experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,6 +1062,7 @@ def test_enrollments_query_analysis_unit(analysis_unit):
WITH raw_enrollments AS (
SELECT
e.{analysis_unit.value} AS analysis_id,
udf.safe_sample_id({analysis_unit.value}) AS sample_id,
`mozfun.map.get_key`(e.event_map_values, 'branch')
AS branch,
MIN(e.submission_date) AS enrollment_date,
Expand Down
Loading