This repository was archived by the owner on Jan 14, 2020. It is now read-only.
[WIP] Host evidence uploaded to openbadger via "issue with evidence" #324
Open
ghost wants to merge 2 commits intomozilla:v2.0from
Open
[WIP] Host evidence uploaded to openbadger via "issue with evidence" #324ghost wants to merge 2 commits intomozilla:v2.0from
ghost wants to merge 2 commits intomozilla:v2.0from
Conversation
|
Hey Erik, Lots of good questions. Viewing evidence once public Reference info Access to publishing Is it possible to see what the page looks like so we can review? Thx! ✌️ |
|
Yeah would definitely like to check it out too to have a visual reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes openbadger hold on to the evidence uploaded via the "Issue One With Evidence" functionality, rather than destroying the evidence once the badge is claimed. It also adds an evidence display page which can be found at /badge/evidence/
Note that there isn't currently any natural way to navigate to this new evidence display page, nor is the page itself particularly attractive. I was worried about displaying any user information on the page, so it doesn't have any indication as to whose badge you are looking at, which makes it feel a little weird. Currently this page requires no authentication, simply because I wasn't sure how private evidence is supposed to be. Should it be admin-only?
I welcome any comments, as I'm not especially happy with this implementation, and regard it as a very rough first pass.