Conversation
Contributor
Author
|
WARNING: This change is currently untested. |
englehardt
suggested changes
Jun 30, 2020
englehardt
approved these changes
Jul 24, 2020
vringar
pushed a commit
that referenced
this pull request
Apr 9, 2021
* updated get_option_dict * Verified mapping * Getting blockers to work without files * Wrapped get_matching rules to bind blockers in scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous crawls apparently got the internal values as ints instead of a string.
I have now updated the implementation to handle the strings and moved get_matching_rules into the library