Added the optional param enable_silverman_kde to loaders and treeherder logic#1027
Merged
kala-moz merged 4 commits intomozilla:mainfrom Apr 10, 2026
Merged
Added the optional param enable_silverman_kde to loaders and treeherder logic#1027kala-moz merged 4 commits intomozilla:mainfrom
kala-moz merged 4 commits intomozilla:mainfrom
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
=======================================
Coverage 96.18% 96.19%
=======================================
Files 111 111
Lines 3148 3155 +7
Branches 712 712
=======================================
+ Hits 3028 3035 +7
Misses 118 118
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmierz
reviewed
Apr 9, 2026
|
|
||
| if (testVersion === MANN_WHITNEY_U || testVersion === null) { | ||
| replicates = true; | ||
| silvermanKDEEnabled = true; |
Contributor
There was a problem hiding this comment.
We'd want this to be false since we don't want to enable it by default. Actually, we might not want to set this here since it would always force the setting into this value right?
gmierz
reviewed
Apr 9, 2026
|
|
||
| if (testVersion === MANN_WHITNEY_U || testVersion === null) { | ||
| replicates = true; | ||
| silvermanKDEEnabled = true; |
Contributor
There was a problem hiding this comment.
I think the same is true here.
gmierz
approved these changes
Apr 10, 2026
Contributor
gmierz
left a comment
gmierz
left a comment
There was a problem hiding this comment.
Works great now, thanks for the quick patch! r+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick PR to enable the Silverman KDE for perfcompare:
Deploy link