Merged
Conversation
craigcook
force-pushed
the
general-link-styles
branch
from
742db5b to
06a3632
Compare
craigcook
force-pushed
the
general-link-styles
branch
3 times, most recently
from
c0df60e to
ef80e3d
Compare
craigcook
force-pushed
the
general-link-styles
branch
from
ef80e3d to
1f1f5e4
Compare
Contributor
Author
|
Just submitted https://github.com/mozilla/protocol-design-tokens/pull/19 to update link color tokens, so we should do that so I can update this PR and get all the colors defined in the proper place. |
craigcook
force-pushed
the
general-link-styles
branch
2 times, most recently
from
abca06e to
86e3bae
Compare
Contributor
Author
|
Color tokens updated, this should be ready for final review/merge. 🔗 |
craigcook
force-pushed
the
general-link-styles
branch
from
86e3bae to
e426307
Compare
michaelmccombie
approved these changes
Apr 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates/adds general link styling. I'm still using the old
_colors.scssfile at the moment since Protocol isn't yet consuming the proper tokens. I think some aspects may still be in flux so I've marked it as "inprogress" pending final decisions on color and style.Meanwhile it can be previewed online and we'll finalize things before merging.
https://demo1--mozilla-protocol.netlify.com/patterns/atoms/links.html