Conversation
|
I updated this to not favor the rel="author", since that was causing one of the tests to fail (a valid failure). |
ffd3c76 to
f08b286
Compare
|
With the new |
This sounds like a good idea for a followup, as discussed IRL. |
Readability.js
Outdated
There was a problem hiding this comment.
Please update the comment. :-)
|
This generally looks great, just a few nits, for which, see my earlier comments. :-) |
Improve byline algorithm. r=Gijs
Still a WIP, as I'll have to rebase on top of #37
This fixes at least these two testcases:
http://www.salon.com/2015/01/02/coca_colas_anti_american_outsourcing_scheme_how_big_soda_gets_the_public_to_shoulder_its_costs/
http://alistapart.com/article/designing-for-easy-interaction
Using the author meta tag is definitely a strict improvement, as is checking the nodes before throwing them away. In order to get the salon.com testcase to work, I added logic for preferring a rel="author" element, but I don't know if that's too specific to that testcase.
Also, I don't like the
var self = this;crap, but it was the quickest way to getting this to work to test :)