Skip to content

Closes #391: Pad series text to be same length as x axis#392

Merged
washort merged 1 commit intomasterfrom
pad-series-text-391
May 3, 2018
Merged

Closes #391: Pad series text to be same length as x axis#392
washort merged 1 commit intomasterfrom
pad-series-text-391

Conversation

@washort
Copy link
Copy Markdown

@washort washort commented May 2, 2018

Labels were not being displayed properly for multiple series when they didn't all have data points for every value on the x axis. This pads it out with nulls to line them up.

closes #391

@washort washort force-pushed the pad-series-text-391 branch from 50dcfb2 to 3221d72 Compare May 2, 2018 23:23
@washort washort changed the title Pad series text to be same length as x axis (fixes #391) Closes #391: Pad series text to be same length as x axis May 2, 2018
@emtwo emtwo self-requested a review May 3, 2018 15:34
Copy link
Copy Markdown

@emtwo emtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @washort! This looks good to me. I'm going to add some details for context and regression testing to be used in the future:

STR:

  1. Create a query with this text:
WITH sample AS
    (SELECT 942094 as client_count, 20180410 as submission_date, 'App 2.0.1 - Android 22' as version UNION
    SELECT 38761 as client_count, 20180409 as submission_date, 'App 2.1 - Android 25' as version UNION
    SELECT 347636 as client_count, 20180429 as submission_date, 'App 2.1 - Android 22' as version)
SELECT * FROM sample
  1. Create a bar graph visualization where X Column is submission_date, Y Columns is client_count, and Group by is version.

Before the bugfix: the y value does not show on hover:
screen shot 2018-05-03 at 12 24 41 pm

After the bugfix: the y value shows on hover:
screen shot 2018-05-03 at 12 22 34 pm

@washort
Copy link
Copy Markdown
Author

washort commented May 3, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Line charts not showing y-axis values for all groups

2 participants