Closes #927, #928: Schema refresh improvements.#930
Merged
Conversation
washort
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
With the faster schema refresh do we still want this longer interval?
Author
There was a problem hiding this comment.
It's not necessary at the moment, but I'm being cautious because the column examples are still a bit slow since they do select * from table limit 1 for each table. We can always turn it back up if it seems too slow I think.
527eddc to
01ef94d
Compare
01ef94d to
f7c12a2
Compare
emtwo
pushed a commit
that referenced
this pull request
Apr 4, 2019
emtwo
pushed a commit
that referenced
this pull request
Apr 4, 2019
emtwo
pushed a commit
that referenced
this pull request
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a variety of changes to fix bugs and more gracefully handle schema processing for data sources with many tables. A summary: