StringBuilder/Buffer support in scripting broken

[p-bakker]

I think due to 141dc4f#diff-8f122a374db26c040ca0460f9c5b4541L1015 it is no longer possible to utilize StringBuffer/Builder in JavaScript, as all instances of CharSequence become ConString instances or something.

While I understand that the ConString optimization alleviates the need to use StringBuffer/Builder, it breaks existing code and makes inline Java code clumsy, for example the implementation of the characters method of org.xml.sax.helpers.DefaultHandler now looks something like cellValue += new java.lang.String["(char[])"](chars.slice(start, start + length)), whereas before it looked like cellValue.append(chars, start, length)

[gbrail]

I can understand this this changed things. However that particular change was merged in 2011 and it'd probably make things worse in different ways to change it now.

As I recall the Nashorn Engine in Java 8 and 9 does the same thing, and in fact that bit of it was written by the same developer.

ConsString does include a toString() method which flattens the string if it needs flattening...

[p-bakker]

See renewed discussion here