Es2022 at method #1289
Es2022 at method #1289
Conversation
…ary operator in all functions
|
Some of the other NativeArray methods implementations check whether the instance being operated on is an instance of NativeArray and then whether the instance.denseOnly flag is set to true. Not sure if such a branch in the code would be applicable for the .at() method as well. To my knowledge the .denseOnly flag is related to a performance optimize |
…ded test cases based on Test262 standards and V8 behavior
src/org/mozilla/javascript/typedarrays/NativeTypedArrayView.java
Outdated
Show resolved
Hide resolved
rbri
left a comment
rbri
left a comment
There was a problem hiding this comment.
can you please move your tests to org.mozilla.javascript.tests.es2022
Done - 8ea870b |
|
@JohnBain thanks, hopefully i find some time today to have a mor detailed look at this |
|
|
||
| private static Object js_at(Context cx, Scriptable scope, Scriptable thisObj, Object[] args) { | ||
| Scriptable o = ScriptRuntime.toObject(cx, scope, thisObj); | ||
| Object targetArg = (args.length >= 1) ? args[0] : Undefined.instance; |
There was a problem hiding this comment.
ScriptRuntime has overloaded variants of toInteger that might be a better fit here, like public static double toNumber(Object[] args, int index)
|
|
||
| private Object js_at(Context cx, Scriptable scope, Scriptable thisObj, Object[] args) { | ||
| Object targetArg = (args.length >= 1) ? args[0] : Undefined.instance; | ||
| int relativeIndex = (int) ScriptRuntime.toInteger(targetArg); |
There was a problem hiding this comment.
similar comment as the one above
|
This looks like a pretty complete and self-contained PR. We have two outstanding comments that could make the code a bit simpler (but I'm not actually 100% sure of that). Would you all be OK if we merged this now? |
|
@p-bakker will have a look at your comments in the next step.... |
|
@JohnBain thanks for the pr |
5 participants
Addresses issue #1051 , adding .at function to the indexed data types Array, TypedArray and String.