NativeRegExp: Fix the behaviour of sticky flag #1828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behaviour of NativeRegExp's exec with the sticky flag on was broken in cases where the regular expression does not start with a literal. This explains why the test262 https://github.com/tc39/test262/blob/main/test/built-ins/RegExp/prototype/exec/y-fail-lastindex.js test passed.
Collaborator
|
Looks good to me. Does this really not fix any test262 tests that were failing before? It seems like there should be some coverage for this feature in a standard test suite that we can use too. |
Contributor
Author
|
@gbrail thanks for taking a look. I realised the PR description needed some work - I've improved it now. It seems to me that Test262 isn’t meant to be exhaustive, and that the test built-ins/RegExp/prototype/exec/y-fail-lastindex.js is intended to cover the feature (though the test itself could be improved with better assertions). I’m still getting familiar with how this works, so I’d really appreciate any insights you might have. |
Collaborator
|
This also looks good, and thanks again. And this will probably require that you rebase your other PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour of NativeRegExp's exec with the sticky flag on was broken in cases where the regular expression does not start with a literal.
This fix doesn't fix any previously failing test262 tests. It seems that this test test/built-ins/RegExp/prototype/exec/y-fail-lastindex.js is the one expected to cover the feature. However this test has always passed since the behaviour of sticky in these "simple" cases are handled as special case.