Fix CLOC metric #146
Merged
Fix CLOC metric #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luni-4
force-pushed
the
fix-cloc
branch
2 times, most recently
from
958d1ae to
3718430
Compare
calixteman
reviewed
Apr 10, 2020
| String | DQUOTE | DQUOTE2 | ExpressionStatement | Block | Module => {} | ||
| Comment => { | ||
| stats.comment_lines.insert(start); | ||
| stats.comment_lines += (end - start) + 1; |
Collaborator
There was a problem hiding this comment.
you probably need to handle the case of multiline comments:
https://twitter.com/gvanrossum/status/112670605505077248
Collaborator
Author
There was a problem hiding this comment.
I added a FIXME in the Python test because I don't know how to discriminate a string used as comment from a simple string
Collaborator
There was a problem hiding this comment.
An idea could be to look for string where the parent is an ExpressionStatement. I'd say that in the case the string is the statement and so this the only thing we've so a comment. Wdyt ?
Collaborator
Author
There was a problem hiding this comment.
Yep, good idea! I'm going to implement that, thanks @calixteman! :)
calixteman
reviewed
Apr 10, 2020
calixteman
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOCCLOCexplanation to the READMEThanks in advance for your review! :)