Final submodule script version #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luni-4
force-pushed
the
final-submodule-script
branch
from
06aceb4 to
41d3471
Compare
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
=======================================
Coverage 23.26% 23.26%
=======================================
Files 45 45
Lines 5489 5489
Branches 805 805
=======================================
Hits 1277 1277
Misses 3690 3690
Partials 522 522 Continue to review full report at Codecov.
|
marco-c
reviewed
Dec 23, 2020
marco-c
reviewed
Dec 23, 2020
marco-c
reviewed
Dec 23, 2020
marco-c
reviewed
Dec 23, 2020
Luni-4
force-pushed
the
final-submodule-script
branch
2 times, most recently
from
45d141a to
fcbbeec
Compare
Since a CI system uses the commit present in a repository that already contain the differences, it is not necessary to update the tree-sitter-language
The two software now used to compare metrics are written in Rust and provide a considerable speed up on large repositories.
Luni-4
force-pushed
the
final-submodule-script
branch
from
fcbbeec to
cf3a2e7
Compare
marco-c
reviewed
Dec 23, 2020
Comment on lines
+265
to
+274
| print(f"Cloning rust-code-analysis master branch into /tmp") | ||
| run_subprocess( | ||
| "git", | ||
| "clone", | ||
| "--depth=1", | ||
| "--recurse-submodules", | ||
| "-j8", | ||
| "https://github.com/mozilla/rust-code-analysis", | ||
| rca_path, | ||
| ) |
Collaborator
There was a problem hiding this comment.
We already have a local clone, we can just reuse it by checking out to master instead of recloning.
Collaborator
Author
There was a problem hiding this comment.
Some CI systems fetch a single branch and you need to reset commits and make complicated stuff to retrieve master branch's commits. This solution could potentially be used on any CI system. It takes less than a second, so we could maintain it imho
marco-c
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #400
Fixes #367
This PR provide the final script to compute and compare metrics in order to verify whether there are differences among each tree-sitter-language update.
The changes present in this PR are:
Thanks in advance for your review! :)