Skip to content

Fix crate publishing #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marco-c merged 1 commit into from
Jan 11, 2021
Merged

Fix crate publishing #420

marco-c merged 1 commit into from
Jan 11, 2021

Conversation

@Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Jan 11, 2021

This PR fixes #412

@Luni-4 Luni-4 requested a review from marco-c January 11, 2021 13:18
@marco-c marco-c merged commit 4d83fe2 into mozilla:master Jan 11, 2021
@marco-c
Copy link
Collaborator

marco-c commented Jan 11, 2021

I forgot, we also need to run cargo package as part of the Linux release build task, to ensure the package works as expected (this way using --no-verify for publish actually has no real effect).

@Luni-4 Luni-4 deleted the fix-publish branch January 11, 2021 14:59
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
@Luni-4 @spacedragon
Fix crate publishing (mozilla#420)
d3b2554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-c marco-c marco-c approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cargo publish fails on CI

2 participants

@Luni-4 @marco-c