Skip to content

Conversation

@Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Jan 13, 2021

This function has never been used internally and furthermore contains unsafe code

@Luni-4 Luni-4 requested a review from marco-c January 13, 2021 14:39
@codecov-io
Copy link

Codecov Report

Merging #427 (5c46eb3) into master (d5323a3) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
- Coverage   22.18%   22.18%   -0.01%     
==========================================
  Files          45       45              
  Lines        5797     5793       -4     
  Branches      822      821       -1     
==========================================
- Hits         1286     1285       -1     
+ Misses       3988     3985       -3     
  Partials      523      523              
Impacted Files Coverage Δ
src/macros.rs 28.33% <ø> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5323a3...5c46eb3. Read the comment docs.

@Luni-4 Luni-4 mentioned this pull request Jan 14, 2021
@marco-c marco-c merged commit b38ade9 into mozilla:master Jan 15, 2021
@Luni-4 Luni-4 deleted the remove-unsafe branch January 15, 2021 10:30
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants