This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Conversation
…o be installable directly from github See yarnpkg/yarn#5235
This was referenced Jan 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v6.0: Rip out most functionality, keeping only some helpful utils that neither the Normandy WebExtension API nor the Nextgen study example currently provides.
See the new README for an overview of the features of v6.
Note that V6 and the use of the built-in Normandy add-on study support makes the following issues irrelevant, since they are fixed elsewhere (not via this repo):
Unenroll via Normandy yields
ReferenceError: setTimeout is not definedfixed-elsewhereFixes #296 opened on Jul 11 by motin
"Enter" and "installed" pings are wrongly generated after updating the browser bug fixed-elsewhere
Fixes #286 opened on Feb 18 by motin
small-study example isn't self contained fixed-elsewhere improve-engineering
Fixes #281 opened on Dec 12, 2018 by pdehaan
Add/use an "error" ending fixed-elsewhere improve-analysis
Fixes #272 opened on Nov 16, 2018 by motin
integrate ending changes into utils fixed-elsewhere pr submitted
Fixes #267 opened on Sep 14, 2018 by gregglind
DECISIONS: Provide guidelines on how all Shield add-on studies should behave in general cases fixed-elsewhere improve-testing
Fixes #252 opened on Jul 28, 2018 by motin
Despite claims to the contrary by me, Disable doesn't actually force uninstall. fixed-elsewhere pr submitted
Fixes #247 opened on Jul 13, 2018 by gregglind
Document onEndStudy properly, including survey arguments fixed-elsewhere improve-docs
Fixes #223 opened on Jun 26, 2018 by gregglind
Multicall on 'ending' should be a 'info' not an 'error' bug fixed-elsewhere
Fixes #221 opened on Jun 25, 2018 by gregglind
Proposed: require all study add-ons to have id's ending with @shield.mozilla.org or @pioneer.mozilla.org fixed-elsewhere improve-analysis
Fixes #209 opened on Jun 20, 2018 by motin
Make it easier to try/test different study endings fixed-elsewhere improve-engineering
Fixes #208 opened on Jun 19, 2018 by gregglind
Add tests for small-study fixed-elsewhere improve-testing
Fixes #172 opened on May 2, 2018 by motin
Eventually fix the helper addon, which can be made with SSAU. fixed-elsewhere improve-testing
Fixes #169 opened on Apr 26, 2018 by gregglind
Add tests and test utils for testing persistent and restart features fixed-elsewhere help wanted improve-testing v5
Fixes #143 opened on Apr 6, 2018 by motin
Improve QA addon ideas fixed-elsewhere improve-testing
Fixes #99 opened on Oct 17, 2017 by gregglind