fix: add bq dataViewer to folder_additional_roles #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code in https://github.com/mozilla/terraform-modules/blob/main/google_permissions/other_roles.tf suggests this should be a role allowed to be added to `folder_roles` input This roles absence from the locals defined here causes the error "You have specified an invalid folder role." to be raised when this option is attempted
corbanCloud
changed the title
Contributor
Release plan
|
jasonthomas
approved these changes
Jan 14, 2025
Author
|
Looks like I'm still getting a folder roles validation error, we may need to re-open this issue, checking on a few things first Edit: module was pinned to a prior version disregard this comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code in https://github.com/mozilla/terraform-modules/blob/main/google_permissions/other_roles.tf suggests this should be a role allowed to be added to
folder_rolesinputThis roles absence from the locals defined here causes the error "You have specified an invalid folder role." to be raised when this option is attempted
Changelog entry