This repository was archived by the owner on Jul 31, 2019. It is now read-only.
Added localized strings to editor.properties for InlineBorderRadiusEditor extension#2585
Merged
gideonthomas merged 18 commits intomozilla:masterfrom Jan 5, 2018
Merged
Added localized strings to editor.properties for InlineBorderRadiusEditor extension#2585gideonthomas merged 18 commits intomozilla:masterfrom
gideonthomas merged 18 commits intomozilla:masterfrom
Conversation
added 17 commits
September 30, 2017 16:08
Contributor
|
Assigning to @gideonthomas for review |
gideonthomas
suggested changes
Jan 4, 2018
Contributor
gideonthomas
left a comment
gideonthomas
left a comment
There was a problem hiding this comment.
Requesting a couple of string changes. I'll make the corresponding changes in brackets.
locales/en-US/editor.properties
Outdated
| ## EXTENSIONS ## | ||
| ################ | ||
| # extensions/default/InlineBorderRadiusEditor | ||
| ALL_CORNERS=All Corners |
Contributor
There was a problem hiding this comment.
Add a comment above this explaining that "All Corners" is an option that can be selected for border-radius.
locales/en-US/editor.properties
Outdated
| # extensions/default/InlineBorderRadiusEditor | ||
| ALL_CORNERS=All Corners | ||
| INDIVIDUAL_CORNERS=Individual Corners | ||
| TL_RADIO_PX=pixels |
Contributor
There was a problem hiding this comment.
All these strings are the same. Just use PIXEL_UNIT=pixels, EM_UNIT=em font unit, PERCENTAGE_UNIT=percentage
| ################ | ||
| # extensions/default/InlineBorderRadiusEditor | ||
| ALL_CORNERS=All Corners | ||
| INDIVIDUAL_CORNERS=Individual Corners |
Contributor
Author
|
@gideonthomas I updated the strings, I think we are almost there. Let me know if there is anything else I need to add/modify |
gideonthomas
approved these changes
Jan 5, 2018
Contributor
gideonthomas
left a comment
gideonthomas
left a comment
There was a problem hiding this comment.
Looks great! Thanks @feihaozi77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@humphd I Added the strings to the edtitor.properties file for InlineBorderRadiusEditor. Please review