Don't check for landed landing unless we applied patches#1022
Open
Don't check for landed landing unless we applied patches#1022
Conversation
Previously if we hit a problem applying the first patch for landing we'd be left with just the base branch, and this code would incorrectly determine that all the changes were already landed. We can't land everything until the head commit is a landing commit, so check for that.
denschub
approved these changes
Oct 6, 2021
Member
denschub
left a comment
denschub
left a comment
There was a problem hiding this comment.
This makes sense. The commit overview is showing failing tests, but unfortunately, the logs have expired, so it's probably good to re-trigger CI here to see what's wrong (or to verify that nothing is wrong)
Member
Author
|
Yeah, so this is a) an important bug fix and b) breaks tests which turn out to be implicitly relying on the old behaviour. So some more work is needed to land this :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if we hit a problem applying the first patch for landing
we'd be left with just the base branch, and this code would
incorrectly determine that all the changes were already landed. We
can't land everything until the head commit is a landing commit, so
check for that.