Conversation
Replace preview SDK version '10.0.200-preview.0.26103.119' with stable release '10.0.0' as per project requirements to not use preview versions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Convert IssueManager.sln to IssueManager.slnx using the modern Visual Studio 2022 solution format. This provides better performance and cleaner structure for .NET projects. Also includes global.json SDK version update to stable 10.0.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Test Results Summary0 tests 0 ✅ 0s ⏱️ Results for commit 11e4f1c. |
There was a problem hiding this comment.
Pull request overview
Updates repo-level build scaffolding by pinning a stable .NET SDK in global.json and migrating the solution definition from the legacy .sln format to a new .slnx file so builds/tests can target the intended project set.
Changes:
- Update
global.jsonSDK pin (and roll-forward settings). - Add
IssueManager.slnxlisting all src + test projects. - Remove the legacy
IssueManager.sln.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| global.json | Pins .NET SDK version and roll-forward behavior for consistent local/CI builds. |
| IssueManager.slnx | Introduces the new solution format and enumerates all projects to build/test. |
| IssueManager.sln | Removes the old Visual Studio solution file in favor of .slnx. |
Comments suppressed due to low confidence (1)
global.json:6
global.jsoncurrently mixes spaces and tabs for indentation. The repo’s.editorconfigspecifies tab indentation for*.json, so this file should be reformatted to use tabs consistently to avoid formatting churn across editors/CI.
{
"sdk": {
"version": "10.0.100",
"rollForward": "latestMinor",
"allowPrerelease": false
}
| <Project Path="src\AppHost\AppHost.csproj" /> | ||
| <Project Path="src\ServiceDefaults\ServiceDefaults.csproj" /> | ||
| <Project Path="src\Shared\Shared.csproj" /> | ||
| <Project Path="src\Api\Api.csproj" /> | ||
| <Project Path="src\Web\Web.csproj" /> | ||
| <Project Path="tests\Unit\Unit.csproj" /> | ||
| <Project Path="tests\Architecture\Architecture.csproj" /> | ||
| <Project Path="tests\BlazorTests\BlazorTests.csproj" /> | ||
| <Project Path="tests\Integration\Integration.csproj" /> | ||
| <Project Path="tests\Aspire\Aspire.csproj" /> | ||
| <Project Path="tests\E2E\E2E.csproj" /> |
There was a problem hiding this comment.
Switching the repo to the new IssueManager.slnx file while deleting IssueManager.sln will break existing CI jobs that still build IssueManager.sln (e.g., .github/workflows/test.yml uses dotnet build IssueManager.sln). Either update those workflows/scripts to use IssueManager.slnx or keep the .sln file to avoid CI failures.
| { | ||
| "sdk": { | ||
| "version": "10.0.200-preview.0.26103.119" | ||
| "version": "10.0.100", | ||
| "rollForward": "latestMinor", | ||
| "allowPrerelease": false | ||
| } |
There was a problem hiding this comment.
CI configuration references Global.json (capital G) as the global-json-file (see .github/workflows/squad-ci.yml), but the repository file is global.json. On Linux runners this casing mismatch will cause the setup step to fail unless the file is renamed or the workflow is updated.
.squad/ files now live on main by design (Decision #10). Guard should only block .squad/ files in PRs from feature/* branches, not direct pushes to main which are already protected by branch rules. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pull Request
Description
Closes #
Changes
Type of Change
Testing
Checklist
docs/CONTRIBUTING.md)Squad Label
Review Notes
Screenshots / Videos