Revert to .sln format for CI/CD compatibility#13
Conversation
The .slnx format is not supported by GitHub Actions dotnet restore and build steps. Reverting to legacy .sln format to restore CI/CD compatibility. Changes: - Created IssueManager.sln with all projects in correct order - Updated squad-ci.yml to reference .sln instead of .slnx - Recorded directive reversal in team decisions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Removed IssueManager.slnx to consolidate on legacy .sln format for GitHub Actions CI compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Reintroduces a legacy IssueManager.sln solution file and updates CI to build it, addressing GitHub Actions compatibility issues with the .slnx format.
Changes:
- Added
IssueManager.slnincluding all src and test projects. - Updated
.github/workflows/squad-ci.ymlto buildIssueManager.slninstead ofIssueManager.slnx. - Added a decision record documenting the directive reversal back to
.sln.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
IssueManager.sln |
Adds a legacy solution file intended to be used by CI instead of .slnx. |
.github/workflows/squad-ci.yml |
Switches the build step to target IssueManager.sln. |
.ai-team/decisions/inbox/copilot-directive-sln-revert.md |
Documents the decision to revert CI processes to .sln. |
| @@ -0,0 +1,79 @@ | |||
|
|
|||
There was a problem hiding this comment.
IssueManager.sln starts with an empty first line. MSBuild’s solution parser expects the format header to be the first line; the leading blank line can cause solution load/build failures in CI. Remove the initial blank line so the file begins with Microsoft Visual Studio Solution File, Format Version 12.00.
| @@ -77,7 +77,7 @@ jobs: | |||
| run: dotnet restore | |||
There was a problem hiding this comment.
The workflow still runs dotnet restore without specifying a solution/project. Since IssueManager.slnx still exists at the repo root, restore can pick up the .slnx (and fail) depending on how MSBuild resolves the default. Call dotnet restore IssueManager.sln (or pass the same solution used for build) to make the CI behavior deterministic.
| run: dotnet restore | |
| run: dotnet restore IssueManager.sln |
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.11.35312.102 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AppHost", "src\AppHost\AppHost.csproj", "{7B8D5A1A-1C1B-4E5F-8F5A-1B1B1B1B1B1B}" |
There was a problem hiding this comment.
This PR’s goal is to revert processes to the legacy .sln format, but IssueManager.slnx is still present in the repo root. Keeping both formats increases the chance that local scripts/CI steps that omit an explicit solution (e.g., dotnet restore from the repo root) will select the wrong one. Consider removing IssueManager.slnx (or clearly documenting that only IssueManager.sln should be used) to avoid ongoing ambiguity.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
The .slnx format is not supported by GitHub Actions dotnet restore and build steps. Reverting to legacy .sln format to restore CI/CD compatibility.
Changes:
Pull Request
Description
Closes #
Changes
Type of Change
Testing
Checklist
docs/CONTRIBUTING.md)Squad Label
Review Notes
Screenshots / Videos