fix(ci): update squad-release.yml to use GitVersion#7
Conversation
- Replace Node.js setup with .NET setup (actions/setup-dotnet@v5) - Integrate GitVersion (version 6.3.0) matching squad-ci.yml pattern - Extract semantic version from GitVersion outputs (majorMinorPatch) - Remove package.json version reading (incompatible with .NET project) - Remove Node.js test step (no Node.js tooling in project) - Preserve tag deduplication and release creation logic Release automation now sources version from GitVersion instead of Node.js package.json, aligning with CI pipeline. This ensures a single source of truth for semantic versioning across all workflows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the release workflow from Node.js/package.json-based versioning to .NET/GitVersion-based versioning, aligning it with the existing CI pipeline pattern. The release automation was previously non-functional for this .NET 10.0 project because it was attempting to read versions from a non-existent package.json file and run Node.js tests.
Changes:
- Replaced Node.js tooling with .NET setup and GitVersion integration in the release workflow
- Updated version extraction to use GitVersion's
majorMinorPatchoutput instead of package.json - Removed incompatible Node.js test execution from the release workflow
- Added comprehensive decision documentation and agent history logging
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/squad-release.yml | Replaced Node.js setup with .NET setup, integrated GitVersion (matching squad-ci.yml pattern), updated version extraction logic |
| .ai-team/decisions/inbox/elrond-gitversion-release.md | New decision document detailing the problem, solution, implementation, and architectural rationale for GitVersion integration |
| .ai-team/agents/elrond/history.md | Added history entry documenting the release workflow fix, including root cause analysis and impact assessment |
| uses: actions/setup-dotnet@v5 | ||
| with: | ||
| node-version: 22 | ||
| global-json-file: Global.json |
There was a problem hiding this comment.
The workflow references 'Global.json' but the actual file in the repository is named 'global.json' (lowercase). While this may work on case-insensitive filesystems (like macOS/Windows), it will fail on case-sensitive filesystems used by GitHub Actions runners (Linux). The reference should be changed to 'global.json' to match the exact filename.
| global-json-file: Global.json | |
| global-json-file: global.json |
Release automation now sources version from GitVersion instead of Node.js package.json, aligning with CI pipeline. This ensures a single source of truth for semantic versioning across all workflows.
Pull Request
Description
Closes #
Changes
Type of Change
Testing
Checklist
docs/CONTRIBUTING.md)Squad Label
Review Notes
Screenshots / Videos