Remove pyca/cryptography backend's dependency on python-ecdsa#117
Merged
mpdavis merged 8 commits intompdavis:backend-explicit-testsfrom Dec 27, 2018
Merged
Remove pyca/cryptography backend's dependency on python-ecdsa#117mpdavis merged 8 commits intompdavis:backend-explicit-testsfrom
mpdavis merged 8 commits intompdavis:backend-explicit-testsfrom
Conversation
commands_pre requires tox >= 3.4.0
This was referenced Dec 25, 2018
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
pyca/cryptographybackend was dependent onpython-ecdsato handle the conversion between DER encoded signatures and the raw signature encoding that JOSE uses.This fixes that, using the DSS encoding/decoding utilities provided in
pyca/cryptographyand adding simplified raw signature encoding and decoding directly.Also added in here are modifications to the tox and Travis CI configurations to remove
python-ecdsaandpython-rsawhen testing thepyca/cryptographybackend in isolation. This is a workaround until we can determine how best to remove those dependencies when the "cryptography" extras is selected.NOTE: The
algorithms/test_RSA.py::test_cryptography_RSA_key_instancetest in the "compatibility" test runs will still fail. That is addressed separately in #116. The "base" test runs also still fail, as discussed in #114.