Prep backend-explicit-tests for merge#128
Merged
zejn merged 6 commits intompdavis:backend-explicit-testsfrom Apr 7, 2019
Merged
Prep backend-explicit-tests for merge#128zejn merged 6 commits intompdavis:backend-explicit-testsfrom
zejn merged 6 commits intompdavis:backend-explicit-testsfrom
Conversation
These are useful to downstreams, such as linux packagers.
Do not fail in JWT decode() if at_hash claim is missing
Include docs and tests in sdists
12 tasks
Codecov Report
@@ Coverage Diff @@
## backend-explicit-tests #128 +/- ##
==========================================================
- Coverage 96.53% 96.52% -0.01%
==========================================================
Files 14 14
Lines 1068 1065 -3
==========================================================
- Hits 1031 1028 -3
Misses 37 37
Continue to review full report at Codecov.
|
Collaborator
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the relative number of changes, I figured it would be better to merge
masterintobackend-explicit-testsfirst before mergingbackend-explicit-testsintomaster. That way the changes are smaller and more reviewable.Next step from here will simply be merging
backend-explicit-testsintomaster.