Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 14 14
Lines 1065 1065
=======================================
Hits 1028 1028
Misses 37 37Continue to review full report at Codecov.
|
Collaborator
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #129, I would like to propose that python-jose officially state what versioning policy the project is following. While there seems to be tentative agreement that the project is following SemVer already, it would be great if that could be explicitly stated. This will make it much simpler for consumers of this library to reason about how to handle upgrades and will help the maintainers in deciding how changes should manifest in new versions.