Just emit a warning when verifying with a private key#168
Merged
blag merged 8 commits intompdavis:masterfrom Dec 20, 2019
Merged
Just emit a warning when verifying with a private key#168blag merged 8 commits intompdavis:masterfrom
blag merged 8 commits intompdavis:masterfrom
Conversation
Some backends are smart and know how to verify with private keys too. Disallow that on those backends.
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
+ Coverage 96.57% 97.18% +0.61%
==========================================
Files 14 14
Lines 1079 1067 -12
==========================================
- Hits 1042 1037 -5
+ Misses 37 30 -7
Continue to review full report at Codecov.
|
blag
force-pushed
the
rsa-privkey-no-verify
branch
from
24c7714 to
e4b92e0
Compare
blag
changed the title
blag
force-pushed
the
rsa-privkey-no-verify
branch
from
5eae276 to
a560fdb
Compare
blag
force-pushed
the
rsa-privkey-no-verify
branch
from
a560fdb to
c25d615
Compare
blag
force-pushed
the
rsa-privkey-no-verify
branch
from
c25d615 to
2d7f481
Compare
blag
force-pushed
the
rsa-privkey-no-verify
branch
from
2d7f481 to
58fc6b3
Compare
blag
force-pushed
the
rsa-privkey-no-verify
branch
from
58fc6b3 to
6a3865b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53.
Closes #142.
Emits warning when user attempts to verify message with a private key.