Merged
Conversation
| if not _sig_matches_keys(keys, signing_input, signature, alg): | ||
| raise JWSSignatureError() | ||
|
|
||
| except JWSSignatureError: |
Contributor
Author
There was a problem hiding this comment.
I was hesitant to change this, but why were you catching JWSSignatureError here, and then re-raising a generic JWSError with text explaining it's a signature failure? Since JWSSignatureError is already a subclass of JWSError, why not just let the JWSSignatureError propagate up?
Current coverage is 95.51%@@ master #29 diff @@
==========================================
Files 7 7
Lines 454 468 +14
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 433 447 +14
Misses 21 21
Partials 0 0
|
Contributor
Author
|
@mpdavis Does this look okay? Any changes you'd like to see? |
Owner
|
@bjmc My apologies for taking so long to get to these. lgtm. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows passing multiple possible keys in the form of a JWK set to
jws.verify()